-
Notifications
You must be signed in to change notification settings - Fork 6
Spelling #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #30
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure about this repository... When I staged things, I tripped on a CI failure from the internal spell checker, but the latest PR visible here has no failures...
Personally, I'm not particularly impressed by the one used and would be happy to talk w/ people about mine...
|
Hey @jsoref, Could you push an empty commit to this branch to trigger the CI? It seems I can no longer approve the CI run |
Signed-off-by: Josh Soref <[email protected]>
|
@mkmkme I've bumped the tip commit. hopefully that works |
|
Please do not merge pull requests that have failing tests. |
This is a misconfiguration of the GitHub repo. I'll look into it. |
|
It is not a misconfiguration -- HOWTO is a typo. HOW-TO or HOW TO would pass the spell checker. I broadly use https://pypi.org/project/codespell. |
It is a misconfiguration since normally a PR with CI failing would not be merged. |
|
For the record, I selected that title because that's the title used by the linked document. It is not an unreasonable default to favor the title of a document when presenting a link. The document in question is: 3.14.0 Documentation » Python HOWTOs » Unicode HOWTOI don't personally care about the spelling of the item, but there is often a tendency in spelling tools not to enforce a spelling against the wishes of someone else. If my name is Fwiw, my dictionary doesn't like There are some groups who insist on doing weird things to names where they rewrite I'm sorry that we missed that the CI had an opinion. Given that it managed to not catch the other things I fixed, I personally don't have a particularly high opinion of the existing CI tooling, but I'm not actively trying to supplant it. |
|
I would do |
|
With mine, you just add items into |
|
No description provided.