Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 17, 2025

No description provided.

jsoref added 5 commits June 16, 2025 20:52
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure about this repository... When I staged things, I tripped on a CI failure from the internal spell checker, but the latest PR visible here has no failures...

Personally, I'm not particularly impressed by the one used and would be happy to talk w/ people about mine...

@mkmkme
Copy link
Collaborator

mkmkme commented Oct 19, 2025

Hey @jsoref,

Could you push an empty commit to this branch to trigger the CI? It seems I can no longer approve the CI run

Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Oct 19, 2025

@mkmkme I've bumped the tip commit. hopefully that works

@mkmkme mkmkme enabled auto-merge (squash) October 19, 2025 16:54
@mkmkme mkmkme merged commit 634c70d into valkey-io:main Oct 19, 2025
33 of 34 checks passed
@jsoref jsoref deleted the spelling branch October 19, 2025 18:25
@cclauss
Copy link
Contributor

cclauss commented Oct 19, 2025

Please do not merge pull requests that have failing tests.

@mkmkme
Copy link
Collaborator

mkmkme commented Oct 19, 2025

Please do not merge pull requests that have failing tests.

This is a misconfiguration of the GitHub repo. I'll look into it.

@cclauss
Copy link
Contributor

cclauss commented Oct 19, 2025

It is not a misconfiguration -- HOWTO is a typo.

HOW-TO or HOW TO would pass the spell checker.

I broadly use https://pypi.org/project/codespell.

@mkmkme
Copy link
Collaborator

mkmkme commented Oct 19, 2025

It is not a misconfiguration -- HOWTO is a typo.

HOW-TO or HOW TO would pass the spell checker.

I broadly use https://pypi.org/project/codespell.

It is a misconfiguration since normally a PR with CI failing would not be merged.
I'll handle this failure and will configure the rules properly. No action is needed from your side.

@cclauss
Copy link
Contributor

cclauss commented Oct 19, 2025

@jsoref
Copy link
Contributor Author

jsoref commented Oct 19, 2025

For the record, I selected that title because that's the title used by the linked document. It is not an unreasonable default to favor the title of a document when presenting a link.

The document in question is:
https://docs.python.org/3/howto/unicode.html#the-string-type

3.14.0 Documentation » Python HOWTOs » Unicode HOWTO


I don't personally care about the spelling of the item, but there is often a tendency in spelling tools not to enforce a spelling against the wishes of someone else. If my name is Josh, it's inappropriate to call me Joseph even if you don't have Josh in your dictionary (and yes, people have a tendency to do this, and yes I get rather angry when they do so).

Fwiw, my dictionary doesn't like HOWTO either.

There are some groups who insist on doing weird things to names where they rewrite colour into color even if the referenced thing has an opinion. If that's the style of a group, then that's ok. But, I personally don't favor that.

I'm sorry that we missed that the CI had an opinion. Given that it managed to not catch the other things I fixed, I personally don't have a particularly high opinion of the existing CI tooling, but I'm not actively trying to supplant it.

@cclauss
Copy link
Contributor

cclauss commented Oct 20, 2025

I would do codespell --ignore-words-list=howto in that tool. Can you propose a similar fix with your spell checker?

@jsoref
Copy link
Contributor Author

jsoref commented Oct 20, 2025

With mine, you just add items into .github/actions/spelling/expect.txt, as seen in https://github.com/check-spelling-sandbox/libvalkey-py/blob/spell-check-with-spelling/.github/actions/spelling/expect.txt

@cclauss
Copy link
Contributor

cclauss commented Oct 20, 2025

  • Spelling #30 broke the build. Please add a new pull request which makes the Continuous Integration tests ✅ again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants